fix: avoid eager interpolation warnings #13520
Open
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seekskyworld
force-pushed
the
fix/12637-interpolation-warning
branch
from
1e5e887 to
75e1fd7
Compare
ndeloof
requested changes
Jan 15, 2026
Contributor
ndeloof
left a comment
ndeloof
left a comment
There was a problem hiding this comment.
compose file loading and processing should be implemented in compose-go
seekskyworld
force-pushed
the
fix/12637-interpolation-warning
branch
from
75e1fd7 to
463a5f1
Compare
Author
|
@ndeloof Updated the PR to align with your guidance: removed the compose-local workaround and now rely on the compose-go fix (compose-spec/compose-go#847) via a temporary go.mod replace. Once the compose-go PR lands, I can switch this to a clean version bump. Tests: go test ./... . |
seekskyworld
force-pushed
the
fix/12637-interpolation-warning
branch
2 times, most recently
from
eb4e58c to
b2a58aa
Compare
Author
|
@ndeloof Thanks! I’ve replaced the temporary fork/replace with the updated compose-go merge-commit version and removed the replace. |
Contributor
|
please squash commits then we can merge |
Signed-off-by: seekskyworld <djh1813553759@gmail.com>
seekskyworld
force-pushed
the
fix/12637-interpolation-warning
branch
from
b2a58aa to
7d54aea
Compare
Author
|
@ndeloof Squashed into a single signed-off commit and force-pushed. Thanks! |
ndeloof
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Summary
Motivation
Validation